Skip to content

Default to Podman, allow Docker optionally #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scottrigby
Copy link
Contributor

updates to #53

@scottrigby scottrigby requested a review from banjoh April 25, 2025 22:23
@scottrigby scottrigby marked this pull request as ready for review April 25, 2025 22:24
@banjoh banjoh merged commit a75abac into replicatedhq:em/dockerize-wg-easy-dependencies Apr 28, 2025
banjoh added a commit that referenced this pull request May 1, 2025
* feat: Dockerfile containing all dependencies for tasks

Signed-off-by: Evans Mungai <[email protected]>

* download helmfile

Signed-off-by: Evans Mungai <[email protected]>

* feat: Dockerfile containing all dependencies for tasks

Signed-off-by: Evans Mungai <[email protected]>

* download helmfile

Signed-off-by: Evans Mungai <[email protected]>

* Add initial docker env taskfile

Signed-off-by: Evans Mungai <[email protected]>

* Move docker tasks into wg-easy application

Signed-off-by: Evans Mungai <[email protected]>

* Update dev documentation

Signed-off-by: Evans Mungai <[email protected]>

* Copy replicated auth token to container

Signed-off-by: Evans Mungai <[email protected]>

* Update dev documentation

Signed-off-by: Evans Mungai <[email protected]>

* Fix grammer

Signed-off-by: Evans Mungai <[email protected]>

* Add SHELL env required by replicated shell subcommand

Signed-off-by: Evans Mungai <[email protected]>

* Default to Podman, allow Docker optionally (#54)

Signed-off-by: Scott Rigby <[email protected]>

* Prepend DEV to dev container variables

Signed-off-by: Evans Mungai <[email protected]>

* Changes as per review comments

Signed-off-by: Evans Mungai <[email protected]>

* Add shell completions and some colour to terminal

Signed-off-by: Evans Mungai <[email protected]>

* Remove duplicate completion

Signed-off-by: Evans Mungai <[email protected]>

* Update applications/wg-easy/container/Containerfile

Co-authored-by: Scott Rigby <[email protected]>

* Update applications/wg-easy/docs/development-workflow.md

Co-authored-by: Scott Rigby <[email protected]>

* Remove unnecessary shell-implementation task

Signed-off-by: Evans Mungai <[email protected]>

* Improvements in Containerfile

Signed-off-by: Evans Mungai <[email protected]>

* Remove unnecessary comment

Signed-off-by: Evans Mungai <[email protected]>

* Build and publish wg-easy tools image to ghcr

Signed-off-by: Evans Mungai <[email protected]>

* Update paths to check in workflow file

Signed-off-by: Evans Mungai <[email protected]>

* Fix repo name

Signed-off-by: Evans Mungai <[email protected]>

* Push in PR

Signed-off-by: Evans Mungai <[email protected]>

* Publish multiarch images

Signed-off-by: Evans Mungai <[email protected]>

* Download architecture specific binaries

Signed-off-by: Evans Mungai <[email protected]>

* Only push when in main branch

Signed-off-by: Evans Mungai <[email protected]>

* Check if image exists locally before pulling or building

When starting the development container, check if the image exists locally before
pulling or building it.

Signed-off-by: Evans Mungai <[email protected]>

* Remove step to build image in docs

dev:shell automatically builds the image if it doesn't exist locally

Signed-off-by: Evans Mungai <[email protected]>

---------

Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Scott Rigby <[email protected]>
Co-authored-by: Scott Rigby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants